linux-kernel - Re: [PATCH] PNPACPI: Enable Power Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081211015052.GA18925@khazad-dum.debian.net>
Date:	Wed, 10 Dec 2008 23:50:52 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Witold Szczeponik <Witold.Szczeponik@....net>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	Adam Belay <abelay@....edu>, rjw@...k.pl
Subject: Re: [PATCH] PNPACPI: Enable Power Support

On Wed, 10 Dec 2008, Henrique de Moraes Holschuh wrote:
> Bah, never mind.  Major issue between the keyboard and the chair, on my
> end...  Got PR# and PS# confused.  The ThinkPad ACPI DSDT in question has
> the standard crap for wake device control, and PR# methods, but no PS#
> methods.
> 
> The PR0..PR2 nodes for the UHCI and EHCI USB ports on the ThinkPad T43
> mention a power resource object, and that power resource CAN power on/off
> the USB ports (and that freaks out the UHCI and EHCI kernel drivers causing
> over-current reports, but that was to be expected).  The AML code tells the
> EC to do some magic that probably tells a MOSFET somewhere in the mainboard
> to stop supplying power to the ports.
> 
> And Windows XP (this is not a Vista BIOS and I never tried running Vista in
> it...) is noticing that power resource (even without PS3 or PR3 nodes) and
> calling that power resource _OFF handler to power down USB ports when it
> doesn't need these devices for wakeup reasons, before entering STR.
> 
> Anyone has any clue on what part of the ACPI spec could result on that
> behaviour?  Because otherwise I will just bloody special-case it into
> thinkpad-acpi's suspend and resume stuff.  It will piss the USB subsystem
> off if I can't arrange to do it on early resume and late suspend, however.

Found it.  ACPI 3.0b, page 238, 7.2 Device Power Management Objects.

"For OSPM to put the device in the D3 state, the following must occur:

All Power Resources no longer referenced by any device in the system must
be in the OFF state"

If you want to put *any* particular ACPI device into D3, you turn off
*every* unused power resource, be them related or not to that device...

Windows XP seems to do it, and powers down the USB ports. None of them are
set for wake-from-S3, they all go to D3 and no references to the power
resources are left.  We probably should be doing the same.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/