linux-kernel - Re: [PATCH] fix calls to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cde8bff0812102014q1ad8f16arf5f4cda96fdf89db@mail.gmail.com>
Date:	Thu, 11 Dec 2008 13:14:06 +0900
From:	"Nguyen Anh Quynh" <aquynh@...il.com>
To:	"Al Viro" <viro@...iv.linux.org.uk>
Cc:	"Andrew Morton" <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Kuniyasu Suzaki" <k.suzaki@...t.go.jp>
Subject: Re: [PATCH] fix calls to request_module()

On Thu, Dec 11, 2008 at 1:01 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Thu, Dec 11, 2008 at 12:35:21PM +0900, Nguyen Anh Quynh wrote:
>> Hi,
>>
>> The request_module() function should always have the 1st param as a
>> format argument. So for example, request_module("i2c-powermac") should
>> be called as request_module("%s", "i2c-powermac"). Otherwise, new gcc
>> like gcc 4.3.2 on Ubuntu 8.10 would spit out a lot of warnings. This
>> patch fixes them all in linus-git tree.
>
> ... and it doesn't address the underlying problems at all.  A string literal
> without a single % in it is a perfectly sane and valid format.  _Why_ are
> we getting these warning?

Hmm, I checked again, and the warnings actually lie elsewhere. I got
mistake while work with several versions at the same time. So please
ignore this patch.

Thanks,
Quynh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/