linux-kernel - Re: [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Dec 2008 12:11:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	Linux-kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c


* Rakib Mullick <rakib.mullick@...il.com> wrote:

> On 12/8/08, Ingo Molnar <mingo@...e.hu> wrote:
> >
> >  * Rakib Mullick <rakib.mullick@...il.com> wrote:
> >
> > no - this just works around the compiler warning.
> >
> >  Look at the real fix below i did some time ago. If you are into fixing
> >  warnings you should try tip/master, that has a ton of warning fixes
> >  already:
> >
> >   http://people.redhat.com/mingo/tip.git/README
> >
> >         Ingo
> Thanks, Ingo for explanation. In 'default_spin_lock_flags' function ,
> the 2nd argument unsigned long flags isn't used in the function. Is it
> necessary to keep it ?

yes, it's a function pointer used in a generic template:

        .spin_lock_flags = default_spin_lock_flags,

.spin_lock_flags() expects that parameter signature - even if in specific 
implementations the parameter might be unused.

	Ingo

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/