[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 12 Dec 2008 16:59:48 +0000
From: Russell King <rmk+lkml@....linux.org.uk>
To: Gerd Hoffmann <kraxel@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v2] Add preadv and pwritev system calls.
On Fri, Dec 12, 2008 at 03:00:40PM +0100, Gerd Hoffmann wrote:
> diff --git a/fs/read_write.c b/fs/read_write.c
> index 969a6d9..89f273d 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -701,6 +701,54 @@ sys_writev(unsigned long fd, const struct iovec __user *vec, unsigned long vlen)
> return ret;
> }
>
> +asmlinkage ssize_t sys_preadv(unsigned long fd, const struct iovec __user *vec,
> + unsigned long vlen, loff_t pos)
For ARM, I'd prefer this to be:
unsigned long fd, const struct iovec __user *vec,
loff_t pos, unsigned long vlen
to avoid any variance in ABIness which will occur with the argument
layout as it currently stands, but that creates a silly argument
order. The other option would be for us to define our own version
in an ARM ABI independent manner:
ssize_t sys_arm_preadv(unsigned long fd, const struct iovec __user *vec,
unsigned long vlen, unsigned long low_pos, unsigned long high_pos)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists