[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <tkrat.aa600853dd4a55d9@s5r6.in-berlin.de>
Date: Sat, 13 Dec 2008 23:09:12 +0100 (CET)
From: Stefan Richter <stefanr@...6.in-berlin.de>
To: linux1394-devel@...ts.sourceforge.net
cc: linux-kernel@...r.kernel.org
Subject: [PATCH 1/2] ieee1394: add quirk fix for Freecom HDD
Date: Sat, 13 Dec 2008 01:43:59 +0100 (CET)
From: Stefan Richter <stefanr@...6.in-berlin.de>
Subject: ieee1394: add quirk fix for Freecom HDD
According to http://bugzilla.kernel.org/show_bug.cgi?id=12206, Freecom
FireWire Hard Drive 1TB reports max_rom=2 but returns garbage if block
read requests are used to read the config ROM. Force max_rom=0 to limit
them to quadlet read requests.
Reported-by: Christian Mueller <cm1@...ac.de>
Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
---
Candidate patch for 2.6.28 and 2.6.27.y.
Christian, please test and confirm that I got this right.
drivers/ieee1394/nodemgr.c | 6 ++++++
1 file changed, 6 insertions(+)
Index: linux/drivers/ieee1394/nodemgr.c
===================================================================
--- linux.orig/drivers/ieee1394/nodemgr.c
+++ linux/drivers/ieee1394/nodemgr.c
@@ -115,8 +115,14 @@ static int nodemgr_bus_read(struct csr12
return error;
}
+#define OUI_FREECOM_TECHNOLOGIES_GMBH 0x0001db
+
static int nodemgr_get_max_rom(quadlet_t *bus_info_data, void *__ci)
{
+ /* Freecom FireWire Hard Drive firmware bug */
+ if (be32_to_cpu(bus_info_data[3]) >> 8 == OUI_FREECOM_TECHNOLOGIES_GMBH)
+ return 0;
+
return (be32_to_cpu(bus_info_data[2]) >> 8) & 0x3;
}
--
Stefan Richter
-=====-==--- ==-- -==-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists