lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081214191233.GB31396@kroah.com>
Date:	Sun, 14 Dec 2008 11:12:33 -0800
From:	Greg KH <greg@...ah.com>
To:	Coly Li <coly.li@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] avoid unnecessary assignment in lookup_bdev()

On Mon, Dec 15, 2008 at 02:33:20AM +0800, Coly Li wrote:
> In normal cases, lookup_bdev() should return successfully, therefore it's not a good idea to always
> assign error values before checking truth/false conditions. This patch modifies code to only assign
> error value in necessary false conditions.
> 
> If I missed something, please correct me.

I don't understand, is there some way that the current code could
incorrectly return an error value?

Is your change somehow faster?  I don't think this is on any fast-path
code, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ