linux-kernel - Re: [PATCH] x86: documentation fix regarding boot protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1229332954.25349.78.camel@zakaz.uk.xensource.com>
Date:	Mon, 15 Dec 2008 09:22:34 +0000
From:	Ian Campbell <ijc@...lion.org.uk>
To:	Philipp Kohlbecher <xt28@....de>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: documentation fix regarding boot protocol

On Sun, 2008-12-14 at 18:50 +0100, Philipp Kohlbecher wrote:
> Documentation/x86/boot.txt describes payload_offset as the offset
> from the end of the real-mode code. In fact, it is more accurately
> described as the offset from the beginning of the protected-mode
> code, as (a) this is how it is actually calculated and (b) the padding
> after the real-mode code is not included in the offset.
> 
> Signed-off-by: Philipp Kohlbecher <xt28@....de>

Acked-by: Ian Campbell <ijc@...lion.org.uk>

The padding after the real-mode code which you mention is just the
implicit padding because the size of the real-mode code is specified in
sectors (and hence is rounded up), isn't it?

Is it worth saying that the payload_offset is relative to (setup_sectors
+1) * 512?

> 
> ---
> 
>   Documentation/x86/boot.txt |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/x86/boot.txt b/Documentation/x86/boot.txt
> index 83c0033..414b6fb 100644
> --- a/Documentation/x86/boot.txt
> +++ b/Documentation/x86/boot.txt
> @@ -537,8 +537,8 @@ Type:		read
>   Offset/size:	0x248/4
>   Protocol:	2.08+
> 
> -  If non-zero then this field contains the offset from the end of the
> -  real-mode code to the payload.
> +  If non-zero then this field contains the offset from the beginning
> +  of the protected-mode code to the payload.
> 
>     The payload may be compressed. The format of both the compressed and
>     uncompressed data should be determined using the standard magic
> 
-- 
Ian Campbell

* weasel wonders how stupid one has to be to spam alt.anonymous.messages
 weasel: about half as stupid as one has to be to harvest it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/