linux-kernel - Re: [PATCH mmotm 1/5] nilfs2: fix problems of memory allocation in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081215101739.GO25779@one.firstfloor.org>
Date:	Mon, 15 Dec 2008 11:17:39 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
Cc:	andi@...stfloor.org, akpm@...ux-foundation.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH mmotm 1/5] nilfs2: fix problems of memory allocation in ioctl

On Mon, Dec 15, 2008 at 03:58:40PM +0900, Ryusuke Konishi wrote:
> On Sun, 14 Dec 2008 16:13:27 +0100, Andi Kleen <andi@...stfloor.org> wrote:
> > > -#define KMALLOC_SIZE_MIN	4096	/* 4KB */
> > > -#define KMALLOC_SIZE_MAX	131072	/* 128 KB */
> > > +#define NILFS_IOCTL_KMALLOC_SIZE	8192	/* 8KB */
> > 
> > Better would be if you could go to PAGE_SIZE. order 0 allocations
> > are typically the fastest / least likely to stall.
> > 
> > Also in this case it's a good idea to use __get_free_pages()
> > directly, kmalloc tends to be become less efficient at larger
> > sizes.
> 
> Thanks again.  I've rewritten the patch to use __get_free_pages().

Thanks looks good now.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/