linux-kernel - Re: [mmotm and linux-next][PATCH] irq: enclose irq_desc_lock_class in CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081216102340.GA1003@elte.hu>
Date:	Tue, 16 Dec 2008 11:23:40 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-next <linux-next@...r.kernel.org>
Subject: Re: [mmotm and linux-next][PATCH] irq: enclose irq_desc_lock_class
	in CONFIG_LOCKDEP


* Ingo Molnar <mingo@...e.hu> wrote:

> > >  #include "internals.h"
> > >  
> > > +#ifdef CONFIG_LOCKDEP
> > >  /*
> > >   * lockdep: we want to handle all irq_desc locks as a single lock-class:
> > >   */
> > >  static struct lock_class_key irq_desc_lock_class;
> > > +#endif
> > >  
> > >  /**
> > >   * handle_bad_irq - handle spurious and unhandled irqs
> > > 
> > 
> > No, lockdep.h (which we forgot to include) already handles that:
> > 
> > # define lockdep_set_class(lock, key)		do { (void)(key); } while (0)
> > 
> > the problem is that the code which references irq_desc_lock_class is
> > inside #ifdef CONFIG_SPARSE_IRQ, so this is a better fix:
> 
> agreed that this is the better fix - applied to tip/irq/sparseirq, 
> thanks!

actually, this breaks the build on !SPARSEIRQ because we will use that 
class in the non-sparseirq case. So we've converted a build warning to a 
build failure ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/