[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081216122731.GC3275@pengutronix.de>
Date: Tue, 16 Dec 2008 13:27:32 +0100
From: Wolfram Sang <w.sang@...gutronix.de>
To: Greg KH <gregkh@...e.de>
Cc: hjk@...utronix.de, linux-kernel@...r.kernel.org,
linuxppc-dev@...abs.org
Subject: adding of_platform_drivers (was: Re: [RESEND][PATCH] uio: Add
of_platform_driver to uio_pdrv_genirq)
> > +/* ---------------------------------------------------------------------
> > + * OF bus binding
> > + */
> > +
> > +#if defined(CONFIG_OF)
>
> Same goes here, don't put #if in .c files please.
So, generally speaking, this means that I should not put a
platform_driver and an of_platform_driver into one source file, but
rather create an of_$DRIVER.c then? I found both ways used in the kernel
and could not find hints about the preferred way to do it. I took this
approach as I hoped it would save some code to directly convert the
of_node to uioinfo without the detour of using a platform_device
inbetween.
Kind regards,
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)
Powered by blists - more mailing lists