linux-kernel - Re: [PATCH 8/11] drivers/net/wireless/libertas: Move a dereference below a NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1229441536.7307.24.camel@localhost.localdomain>
Date:	Tue, 16 Dec 2008 10:32:16 -0500
From:	Dan Williams <dcbw@...hat.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	libertas-dev@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 8/11] drivers/net/wireless/libertas: Move a dereference
	below a NULL test

On Tue, 2008-12-16 at 16:14 +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> In each case, if the NULL test is necessary, then the dereference should be
> moved below the NULL test.  I have also taken advantage of the availability
> of the value of priv->dev in the subsequent calls to netif_stop_queue and
> netif_carrier_off.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@
> type T;
> expression E;
> identifier i,fld;
> statement S;
> @@
> 
> - T i = E->fld;
> + T i;
>   ... when != E
>       when != i
>   if (E == NULL) S
> + i = E->fld;
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Acked-by: Dan Williams <dcbw@...hat.com>

> ---
>  drivers/net/wireless/libertas/main.c           |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c
> index 73dc8c7..91c89da 100644
> --- a/drivers/net/wireless/libertas/main.c
> +++ b/drivers/net/wireless/libertas/main.c
> @@ -1311,7 +1311,7 @@ EXPORT_SYMBOL_GPL(lbs_start_card);
>  
>  void lbs_stop_card(struct lbs_private *priv)
>  {
> -	struct net_device *dev = priv->dev;
> +	struct net_device *dev;
>  	struct cmd_ctrl_node *cmdnode;
>  	unsigned long flags;
>  
> @@ -1319,9 +1319,10 @@ void lbs_stop_card(struct lbs_private *priv)
>  
>  	if (!priv)
>  		goto out;
> +	dev = priv->dev;
>  
> -	netif_stop_queue(priv->dev);
> -	netif_carrier_off(priv->dev);
> +	netif_stop_queue(dev);
> +	netif_carrier_off(dev);
>  
>  	lbs_debugfs_remove_one(priv);
>  	if (priv->mesh_tlv) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/