linux-kernel - Re: [patch 4/8] x86 PAT: hooks in generic vm code to help archs to track pfnmap regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081216121304.a9043cb2.akpm@linux-foundation.org>
Date:	Tue, 16 Dec 2008 12:13:04 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
Cc:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com, npiggin@...e.de,
	hugh@...itas.com, rdreier@...co.com, jbarnes@...tuousgeek.org,
	jeremy@...p.org, arjan@...radead.org, linux-kernel@...r.kernel.org,
	suresh.b.siddha@...el.com
Subject: Re: [patch 4/8] x86 PAT: hooks in generic vm code to help archs to
 track pfnmap regions

On Tue, 16 Dec 2008 12:07:56 -0800
"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com> wrote:

>  
> 
> >-----Original Message-----
> >From: Andrew Morton [mailto:akpm@...ux-foundation.org] 
> >Sent: Tuesday, December 16, 2008 11:57 AM
> >To: Pallipadi, Venkatesh
> >Cc: mingo@...e.hu; tglx@...utronix.de; hpa@...or.com; 
> >npiggin@...e.de; hugh@...itas.com; rdreier@...co.com; 
> >jbarnes@...tuousgeek.org; jeremy@...p.org; 
> >arjan@...radead.org; linux-kernel@...r.kernel.org; Pallipadi, 
> >Venkatesh; Siddha, Suresh B
> >Subject: Re: [patch 4/8] x86 PAT: hooks in generic vm code to 
> >help archs to track pfnmap regions

Your emails are getting mucked up.

> >On Wed, 12 Nov 2008 13:26:51 -0800
> >Venkatesh Pallipadi <venkatesh.pallipadi@...el.com> wrote:
> >
> >> --- tip.orig/mm/memory.c	2008-11-11 10:10:11.000000000 -0800
> >> +++ tip/mm/memory.c	2008-11-11 12:10:18.000000000 -0800
> >> @@ -99,6 +99,28 @@ int randomize_va_space __read_mostly =
> >>  					2;
> >>  #endif
> >>  
> >> +#ifndef track_pfn_vma_new
> >> +int track_pfn_vma_new(struct vm_area_struct *vma, pgprot_t prot,
> >> +			unsigned long pfn, unsigned long size)
> >> +{
> >> +	return 0;
> >> +}
> >> +#endif
> >> +
> >> +#ifndef track_pfn_vma_copy
> >> +int track_pfn_vma_copy(struct vm_area_struct *vma)
> >> +{
> >> +	return 0;
> >> +}
> >> +#endif
> >> +
> >> +#ifndef untrack_pfn_vma
> >> +void untrack_pfn_vma(struct vm_area_struct *vma, unsigned long pfn,
> >> +			unsigned long size)
> >> +{
> >> +}
> >> +#endif
> >
> >Using __weak would provide a somewhat neater result here.
> >
> 
> Thought about that. But, then remembered the issues with gcc versions and __weak, as in here
> http://lkml.org/lkml/2008/5/1/368
> 
> and decided to take the safer approach.
> 

Yes, it is a concern.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/