[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20081217055646.GC14432@gondor.apana.org.au>
Date: Wed, 17 Dec 2008 16:56:46 +1100
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Harvey Harrison <harvey.harrison@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] crypto: salsa20 use endian access helpers
On Mon, Dec 08, 2008 at 05:26:36PM -0800, Harvey Harrison wrote:
>
> @@ -98,40 +91,51 @@ static void salsa20_wordtobyte(u8 output[64], const u32 input[16])
> for (i = 0; i < 16; ++i)
> x[i] += input[i];
> for (i = 0; i < 16; ++i)
> - U32TO8_LITTLE(output + 4 * i,x[i]);
> + store_le32((__le32 *)(output + 4 * i), x[i]);
> }
We need to mark output (i.e., buf) as aligned in the caller.
Otherwise the patch looks good to me.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists