linux-kernel - Re: [PATCH 2/11] drivers/infiniband: Move a dereference below a NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ada7i5z1dyb.fsf@cisco.com>
Date:	Tue, 16 Dec 2008 23:02:52 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	rolandd@...co.com, sean.hefty@...el.com, hal.rosenstock@...il.com,
	general@...ts.openfabrics.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/11] drivers/infiniband: Move a dereference below a NULL test

 > --- a/drivers/infiniband/hw/nes/nes_cm.c
 > +++ b/drivers/infiniband/hw/nes/nes_cm.c
 > @@ -376,13 +376,14 @@ int schedule_nes_timer(struct nes_cm_node *cm_node, struct sk_buff *skb,
 >  		int close_when_complete)
 >  {
 >  	unsigned long  flags;
 > -	struct nes_cm_core *cm_core = cm_node->cm_core;
 > +	struct nes_cm_core *cm_core;
 >  	struct nes_timer_entry *new_send;
 >  	int ret = 0;
 >  	u32 was_timer_set;
 >  
 >  	if (!cm_node)
 >  		return -EINVAL;
 > +	cm_core = cm_node->cm_core;

Thanks... I believe this is already taken care of by a patch pending for
2.6.29 (which should be in -next) that removes the test for NULL.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/