linux-kernel - Re: [PATCH 7/15] sanitize AUDIT_MQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.1.10.0812171839080.22856@tundra.namei.org>
Date:	Wed, 17 Dec 2008 18:40:54 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Al Viro <viro@....linux.org.uk>
cc:	linux-audit@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV

On Wed, 17 Dec 2008, Al Viro wrote:

> 
> * logging the original value of *msg_prio in mq_timedreceive(2)
>   is insane - the argument is write-only (i.e. syscall always
>   ignores the original value and only overwrites it).

I wonder if any existing certifications need to be amended.

> * merge __audit_mq_timed{send,receive}
> * don't do copy_from_user() twice
> * don't mess with allocations in auditsc part
> * ... and don't bother checking !audit_enabled and !context in there -
>   we'd already checked for audit_dummy_context().
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>


Reviewed-by: James Morris <jmorris@...ei.org>

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/