linux-kernel - Re: [PATCH 7/15] sanitize AUDIT_MQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081217080315.GZ28946@ZenIV.linux.org.uk>
Date:	Wed, 17 Dec 2008 08:03:15 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Al Viro <viro@....linux.org.uk>, linux-audit@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV

On Tue, Dec 16, 2008 at 11:56:56PM -0800, Andrew Morton wrote:
> > +		if (copy_from_user(&ts, u_abs_timeout, 
> > +					sizeof(struct timespec)))
> 
> Well that's odd.  afacit timespec has different sizes on 32-bit and
> 64-bit userspace.
> 
> But the old audit code did this copy too, and it presumably worked.

compat_mq_timedsend() et.al. essentially do copy_in_user() converting to
64bit and theh call sys_mq_...().  So you get kernel-native layout in
the log.

Similar for notification in compat_mq_notify(), etc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/