linux-kernel - Re: [patch 68/83] x86: HPET: convert WARN_ON to WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h4p13dojm.wl%tiwai@suse.de>
Date:	Wed, 17 Dec 2008 12:33:17 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Willy Tarreau <w@....eu>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, mingo@...e.hu,
	venkatesh.pallipadi@...el.com, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch 68/83] x86: HPET: convert WARN_ON to WARN_ON_ONCE

At Wed, 17 Dec 2008 11:26:25 +0000,
Matt Fleming wrote:
> 
> On Thu, Dec 11, 2008 at 11:16:20AM -0800, Greg KH wrote:
> > 2.6.27-stable review patch.  If anyone has any objections, please let us know.
> > 
> > ------------------
> > 
> > From: Matt Fleming <mjf@...too.org>
> > 
> > commit 1de5b0854623d30d01d72cd4ea323eb5f39d1f16 upstream.
> > 
> > It is possible to flood the console with call traces if the WARN_ON
> > condition is true because of the frequency with which this function is
> > called.
> > 
> 
> If this commit is going into stable it would be worth adding these
> two commits (which are actually the bugfixes).
> 
> 5ceb1a04187553e08c6ab60d30cee7c454ee139a
> x86: HPET: enter hpet_interrupt_handler with interrupts disabled
> 
> 89d77a1eb60be916d85d9394bedbfa2037af89c5
> x86: HPET: read from HPET_Tn_CMP() not HPET_T0_CMP

I think the latter isn't applicable as 2.6.27 supports only T0.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/