| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081217114807.GD25976@agk.fab.redhat.com> Date: Wed, 17 Dec 2008 11:48:07 +0000 From: Alasdair G Kergon <agk@...hat.com> To: crquan@...il.com Cc: dm-devel@...hat.com, linux-kernel@...r.kernel.org Subject: Re: [dm-devel] [PATCH] dm-target.c: simplify target_type to avoid kmalloc On Tue, Dec 09, 2008 at 07:32:35PM +0800, crquan@...il.com wrote: > Move the list_head from tt_internal into struct target_type embedded, > The struct tt_internal is totally unneeded, and the kmalloc is avoided, > block of memory copy is also avoided > The only defect is that dm_register_target users cannot use const > target_type anymore. Target registrations should be rare one-off events. The existing trade-off is in favour of a cleaner interface (that does not expose private fields). The struct target_type passed to dm_register_target is always static read-only data and perhaps that could be enforced and a pointer stored in tt_internal instead of making a copy. > the function of tt_internal's use field is replaced by the module's > reference count. That is an independent change I think: please submit it as a separate patch. When this was first written, the module reference count was managed differently by this code so I can well believe 'use' is now superfluous. Alasdair -- agk@...hat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists