linux-kernel - Re: [PATCH 4/28] drivers/ide: Drop return value from platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Dec 2008 14:49:46 +0200
From:	Dmitri Vorobiev <dmitri.vorobiev@...ial.fi>
To:	Ben Dooks <ben-linux@...ff.org>
CC:	Julia Lawall <julia@...u.dk>, khali@...ux-fr.org,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, Greg KH <greg@...ah.com>
Subject: Re: [PATCH 4/28] drivers/ide: Drop return value from	platform_driver
 remove functions

Ben Dooks wrote:
> On Wed, Dec 10, 2008 at 05:27:56PM +0100, Julia Lawall wrote:
>> From: Julia Lawall <julia@...u.dk>
>>
>> The return value of the remove function of a driver structure, and thus of
>> a platform_driver structure, is ultimately ignored, and is thus
>> unnecessary.  This patch removes the return value for the remove function
>> stored in a platform_driver structure.
>>
>> For the files drivers/i2c/busses/i2c-at91.c and
>> drivers/i2c/busses/i2c-mv64xxx.c, the original return value was the value
>> of a variable storing the result of calling i2c_del_adapter.  I have thus
>> also deleted the declaration and initialization of this variable.  For the
>> other files, the return values were always 0.
>>
>> A simplified version of the semantic patch that makes this change is as
>> follows: (http://www.emn.fr/x-info/coccinelle/)
> 
> I take it remove_new will eventually be renamed to remove once all
> the changes have been made?
> 
> Unless there are any objections I'll add this to the merge list for
> the next window.

Please be careful since the drivers/base/ part has not been applied yet, so I'm Cc:ing Greg now for his opinion.

Dmitri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/