linux-kernel - Re: [PATCH] cifs: fix buffer overrun in parse_DFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49491D88.3020106@diamondcut.com.br>
Date:	Wed, 17 Dec 2008 13:40:56 -0200
From:	"Renato S. Yamane" <yamane@...mondcut.com.br>
To:	Jeff Layton <jlayton@...hat.com>
CC:	torvalds@...ux-foundation.org, sfrench@...il.com,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	linux-cifs-client@...ts.samba.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] cifs: fix buffer overrun in parse_DFS_referrals

Jeff Layton wrote:
> ---
>  fs/cifs/cifssmb.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index 9395928..824df14 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -3992,7 +3992,8 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
>  
>  		node->flags = le16_to_cpu(pSMBr->DFSFlags);
>  		if (is_unicode) {
> -			__le16 *tmp = kmalloc(strlen(searchName)*2, GFP_KERNEL);
> +			__le16 *tmp = kmalloc(strlen(searchName)*2 + 2,
> +						GFP_KERNEL);
>  			cifsConvertToUCS((__le16 *) tmp, searchName,
>  					PATH_MAX, nls_codepage, remap);
>  			node->path_consumed = hostlen_fromUCS(tmp,

This patch can't be applied in -stable release:

yamane@...dachuva:~/kernel/linux-2.6.27.9$ patch -p1 < cifs.patch
patching file fs/cifs/cifssmb.c
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 3992.
1 out of 1 hunk FAILED -- saving rejects to file fs/cifs/cifssmb.c.rej

Best regards,
Renato
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/