| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Dec 2008 01:33:41 +0900 From: Tejun Heo <tj@...nel.org> To: Steven Rostedt <srostedt@...hat.com> CC: George Spelvin <linux@...izon.com>, peterz@...radead.org, andi@...stfloor.org, linux-kernel@...r.kernel.org Subject: Re: [RFC] globmatch() helper function Steven Rostedt wrote: > On Thu, 2008-12-18 at 01:22 +0900, Tejun Heo wrote: >> Hello, >> >> George Spelvin wrote: >>> Do people think that would be, on balance, better? It would be plenty >>> good enough for the blacklist application. >> Just pass a depth parameter and trigger WARN_ON() and return -EINVAL >> when it exceeds ten. It's a five minute change and should be enough >> for kernel usages. > > If this is ever expected to be used by userspace, I would not include > the WARN_ON. If this is a generic function, then I'll include in in > ftrace as well, and that takes userspace input. The last thing I want is > a DoS because of printk's to the serial console because some userspace > app is constantly writing bad patterns to this file. Well, then, how about printk_ratelimit()? Having one too many asterisk will be a very rare occasion and when it happens it's something which can easily escape attention, so I think some form of whining is in order. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists