linux-kernel - Re: [PATCH] x86 gart: don't complain if no AMD GART found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Dec 2008 21:53:08 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	iommu@...ts.linux-foundation.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, hpa@...or.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86 gart: don't complain if no AMD GART found

On Wed, Dec 17, 2008 at 12:52:34PM -0700, Bjorn Helgaas wrote:
> It's perfectly normal for no AMD GART to be present, e.g., if you have
> Intel CPUs.  None of the other iommu_init() functions makes noise when
> it finds nothing.

True, there are even 64bit AMD processors without GART.

Ingo,

do you want to pick this patch up or should I do it?

> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>

Acked-by: Joerg Roedel <joerg.roedel@....com>

> ---
>  arch/x86/kernel/pci-gart_64.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
> index ba7ad83..a35eaa3 100644
> --- a/arch/x86/kernel/pci-gart_64.c
> +++ b/arch/x86/kernel/pci-gart_64.c
> @@ -745,10 +745,8 @@ void __init gart_iommu_init(void)
>  	unsigned long scratch;
>  	long i;
>  
> -	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0) {
> -		printk(KERN_INFO "PCI-GART: No AMD GART found.\n");
> +	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0)
>  		return;
> -	}
>  
>  #ifndef CONFIG_AGP_AMD64
>  	no_agp = 1;
> 
> 

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/