linux-kernel - Re: trace: fix task state printout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Dec 2008 17:29:18 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Thomas Gleixner <tglx@...utronix.de>
cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: trace: fix task state printout


On Wed, 17 Dec 2008, Thomas Gleixner wrote:

> Impact: tracer task state decoding is wrong, size check is buggy

The Imact line seems more of a subject line. The real Impact line should 
be something like:

Impact: fix wrong decoding of task state int tracer

Keyword is 'fix'

> 
> The tracing code has interesting varieties of printing out task state.
> Unfortunalely only one of the instances is correct as it copies the
> code from sched.c:sched_show_task(). The others are plain wrong as
> they treatthe bitfield as an integer offset into the character
> array. Also the size check of the character array is wrong as it
> includes the trailing \0.
> 
> Use a common state decoder inline which does the Right Thing.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Acked-by: Steven Rostedt <srostedt@...hat.com>


Ingo, this is a low risk fix that probably should be pushed towards Linus 
for inclusion into 2.6.28.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/