linux-kernel - Re: [w1] Allow master IO commands.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081217231941.GA29798@ioremap.net>
Date:	Thu, 18 Dec 2008 02:19:41 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [w1] Allow master IO commands.

On Wed, Dec 17, 2008 at 03:14:18PM -0800, Andrew Morton (akpm@...ux-foundation.org) wrote:
> Do we have checks in there to ensure that we can't run off the end of
> the buffer?

Yes, w1_process_search_command() calls w1_search_devices() with the
w1_send_slave() callback which is invoked each time new slave is
detected. w1_send_slave() checks if amount of available data is enough
to store additional ID and sends message otherwise. The last message is
being sent with the flag indicating that, and it is sent no matter if
there were some slave devices found or not. 

> > Ok, I will space it to the left. Should I sent patch on top of it or
> > instead of?
> 
> Is OK, I'll fix it.  That change messes up the following patches so I
> fixed them as well.

Thanks a lot Andrew!

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/