linux-kernel - Re: [PATCH] x86: traps.c declare functions before they get used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f9a31f40812162028j5a0e12f5h2215daae12ce3441@mail.gmail.com>
Date:	Wed, 17 Dec 2008 09:58:47 +0530
From:	"Jaswinder Singh" <jaswinderlinux@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Jaswinder Singh" <jaswinder@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Andi Kleen" <andi@...stfloor.org>
Subject: Re: [PATCH] x86: traps.c declare functions before they get used

Hello Ingo,

On Wed, Dec 17, 2008 at 1:49 AM, Ingo Molnar <mingo@...e.hu> wrote:
>> +#ifndef CONFIG_MATH_EMULATION
>>  asmlinkage void math_emulate(long);
>>  #endif
>
> uhm, shouldnt that #ifndef CONFIG_MATH_EMULATION be #ifdef
> CONFIG_MATH_EMULATION?
>

Sorry, but it seems correct to me in traps case will be opposite.

If someone tries to access math_emulate() and MATH_EMULATION is not
defined then he will be trapped ;-)

Thank you,

Jaswinder Singh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/