linux-kernel - nbd: fix locking in case of error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081218183310.GA21260@elf.ucw.cz>
Date:	Thu, 18 Dec 2008 19:33:10 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Paul.Clements@...eleye.com,
	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: nbd: fix locking in case of error


This cleans up error handling some more, and prevents return with lock
held from nbd_handle_req when nbd_send_req() fails. It also switches
calling convention of nbd_send_req from 0 = ok, 1 = failed to 0 /
-errno.

Signed-off-by: Pavel Machek <pavel@...e.cz>

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index fcefbe4..d36787d 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -280,7 +280,7 @@ static int nbd_send_req(struct nbd_devic
 	return 0;
 
 error_out:
-	return 1;
+	return -EIO;
 }
 
 static struct request *nbd_find_request(struct nbd_device *lo,
@@ -467,10 +467,9 @@ static void nbd_handle_req(struct nbd_de
 
 	mutex_lock(&lo->tx_lock);
 	if (unlikely(!lo->sock)) {
-		mutex_unlock(&lo->tx_lock);
 		printk(KERN_ERR "%s: Attempted send on closed socket\n",
 		       lo->disk->disk_name);
-		goto error_out;
+		goto error_out_unlock;
 	}
 
 	lo->active_req = req;
@@ -478,7 +477,7 @@ static void nbd_handle_req(struct nbd_de
 	if (nbd_send_req(lo, req) != 0) {
 		printk(KERN_ERR "%s: Request send failed\n",
 				lo->disk->disk_name);
-		goto error_out;
+		goto error_out_unlock;
 	} else {
 		spin_lock(&lo->queue_lock);
 		list_add(&req->queuelist, &lo->queue_head);
@@ -491,6 +490,8 @@ static void nbd_handle_req(struct nbd_de
 
 	return;
 
+error_out_unlock:
+	mutex_unlock(&lo->tx_lock);
 error_out:
 	req->errors++;
 	nbd_end_request(req);
@@ -531,7 +532,7 @@ static int nbd_thread(void *data)
  *   { printk( "Warning: Ignoring result!\n"); nbd_end_request( req ); }
  */
 
-static void do_nbd_request(struct request_queue * q)
+static void do_nbd_request(struct request_queue *q)
 {
 	struct request *req;
 	

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/