linux-kernel - Re: [PATCH, RESEND2] getrusage: fill ru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081218111608.615F.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Thu, 18 Dec 2008 11:50:09 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	"Oleg Nesterov" <oleg@...hat.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Michael Kerrisk" <mtk.manpages@...glemail.com>,
	linux-api@...r.kernel.org, Hugh Dickins <hugh@...itas.com>,
	jlim@....com
Subject: Re: [PATCH, RESEND2] getrusage: fill ru_maxrss value

> > Ah, you talked about /usr/bin/time? sorry, I misunderstood a bit.
> > Why time need number of pages?
> > 
> > In general, getrusage()::ru_maxrss is bsd compatibility feature.
> > as far as possible, the same syscall spec is better.
> > and bsd use KB unit.
> Oh you are right. Now I searched it in FreeBSD kernel. They goes like this:
> rss = pgtok(vmspace_resident_count(vm));
> if (ru->ru_maxrss < rss)
> 	ru->ru_maxrss = rss;
> 
> Seems pretty reasonable to stick with the same behavior. Then I really
> do not understand why /usr/bin/time does the conversion.

me too ;-)

> FreeBSD /usr/bin/time is very different and much simpler and (of
> course) does not do this conversion.
> 
> So I suggest to change the patch to fill KB instead of pages and
> change /usr/bin/time to not do the conversion. What do you think?

Makes really much sense. thanks!!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/