linux-kernel - [PATCH 3/6] drm/i915: fix sparse warnings: move 'extern' decls to header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <494ad5d9.0ab6660a.2341.ffff80b7@mx.google.com>
Date:	Thu, 18 Dec 2008 21:22:24 +0100
From:	Hannes Eder <hannes@...neseder.net>
To:	David Airlie <airlied@...ux.ie>
Cc:	kernel-janitors@...r.kernel.org
Subject: [PATCH 3/6] drm/i915: fix sparse warnings: move 'extern' decls to header file

Move 'extern'-decls from "intel_dvo.c" to "dvo.h", as "dvo.h" is
included by and only by files where the symbols are either defined or
used.

Fix this sparse warnings:

  drivers/gpu/drm/i915/dvo_ch7xxx.c:358:26: warning: symbol 'ch7xxx_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_ch7017.c:444:26: warning: symbol 'ch7017_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_ivch.c:432:26: warning: symbol 'ivch_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_tfp410.c:325:26: warning: symbol 'tfp410_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_sil164.c:292:26: warning: symbol 'sil164_ops' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@...neseder.net>
---
 drivers/gpu/drm/i915/dvo.h       |    6 ++++++
 drivers/gpu/drm/i915/intel_dvo.c |    6 ------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
index e80866c..e747ac4 100644
--- a/drivers/gpu/drm/i915/dvo.h
+++ b/drivers/gpu/drm/i915/dvo.h
@@ -148,4 +148,10 @@ struct intel_dvo_dev_ops {
 	void (*dump_regs)(struct intel_dvo_device *dvo);
 };
 
+extern struct intel_dvo_dev_ops sil164_ops;
+extern struct intel_dvo_dev_ops ch7xxx_ops;
+extern struct intel_dvo_dev_ops ivch_ops;
+extern struct intel_dvo_dev_ops tfp410_ops;
+extern struct intel_dvo_dev_ops ch7017_ops;
+
 #endif /* _INTEL_DVO_H */
diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
index cc621c8..8b8d6e6 100644
--- a/drivers/gpu/drm/i915/intel_dvo.c
+++ b/drivers/gpu/drm/i915/intel_dvo.c
@@ -37,12 +37,6 @@
 #define CH7xxx_ADDR	0x76
 #define TFP410_ADDR	0x38
 
-extern struct intel_dvo_dev_ops sil164_ops;
-extern struct intel_dvo_dev_ops ch7xxx_ops;
-extern struct intel_dvo_dev_ops ivch_ops;
-extern struct intel_dvo_dev_ops tfp410_ops;
-extern struct intel_dvo_dev_ops ch7017_ops;
-
 static struct intel_dvo_device intel_dvo_devices[] = {
 	{
 		.type = INTEL_DVO_CHIP_TMDS,
-- 
1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/