linux-kernel - Re: [PATCH 1/6] drm/i915: fix sparse warnings: declare one-bit bitfield as unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200812181540.34147.jbarnes@virtuousgeek.org>
Date:	Thu, 18 Dec 2008 15:40:33 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	dri-devel@...ts.sourceforge.net
Cc:	Hannes Eder <hannes@...neseder.net>,
	David Airlie <airlied@...ux.ie>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] drm/i915: fix sparse warnings: declare one-bit bitfield as unsigned

On Thursday, December 18, 2008 6:09 am Hannes Eder wrote:
> Fix this sparse warnings:
>
>   drivers/gpu/drm/i915/i915_drv.h:169:22: error: dubious one-bit signed
> bitfield drivers/gpu/drm/i915/i915_drv.h:169:22: warning: dubious bitfield
> without explicit `signed' or `unsigned'
> drivers/gpu/drm/i915/i915_drv.h:170:19: error: dubious one-bit signed
> bitfield drivers/gpu/drm/i915/i915_drv.h:170:19: warning: dubious bitfield
> without explicit `signed' or `unsigned'
> drivers/gpu/drm/i915/i915_drv.h:171:16: error: dubious one-bit signed
> bitfield drivers/gpu/drm/i915/i915_drv.h:171:16: warning: dubious bitfield
> without explicit `signed' or `unsigned'
> drivers/gpu/drm/i915/i915_drv.h:172:23: error: dubious one-bit signed
> bitfield drivers/gpu/drm/i915/i915_drv.h:172:23: warning: dubious bitfield
> without explicit `signed' or `unsigned'
>
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> ---
>  drivers/gpu/drm/i915/i915_drv.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h index 467572a..a640bcf 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -166,10 +166,10 @@ typedef struct drm_i915_private {
>  	struct drm_display_mode *vbt_mode; /* if any */
>
>  	/* Feature bits from the VBIOS */
> -	int int_tv_support:1;
> -	int lvds_dither:1;
> -	int lvds_vbt:1;
> -	int int_crt_support:1;
> +	unsigned int int_tv_support:1;
> +	unsigned int lvds_dither:1;
> +	unsigned int lvds_vbt:1;
> +	unsigned int int_crt_support:1;
>
>  	struct drm_i915_fence_reg fence_regs[16]; /* assume 965 */
>  	int fence_reg_start; /* 4 if userland hasn't ioctl'd us yet */

Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/