lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Dec 2008 14:54:33 +0300 From: Sergei Shtylyov <sshtylyov@...mvista.com> To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/9] ide: remove 'byte' typedef Hello. Bartlomiej Zolnierkiewicz wrote: > Just use u8 instead, also s/__u8/u8/ in ide-cd.h while at it. > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com> > Index: b/drivers/ide/qd65xx.h > =================================================================== > --- a/drivers/ide/qd65xx.h > +++ b/drivers/ide/qd65xx.h > @@ -31,8 +31,8 @@ > > #define QD_CONFIG(hwif) ((hwif)->config_data & 0x00ff) > > -#define QD_TIMING(drive) (byte)(((drive)->drive_data) & 0x00ff) > -#define QD_TIMREG(drive) (byte)((((drive)->drive_data) & 0xff00) >> 8) > +#define QD_TIMING(drive) (u8)(((drive)->drive_data) & 0x00ff) > +#define QD_TIMREG(drive) (u8)((((drive)->drive_data) & 0xff00) >> 8) > Could you drop the pointless parens around (drive)->drive_data, while at it? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists