linux-kernel - Re: [PATCH] ide: Fix ata_id_has_dword_io to return DWORD I/O support properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812192030.34554.bzolnier@gmail.com>
Date:	Fri, 19 Dec 2008 20:30:34 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Sergei Shtylyov <sshtylyov@...mvista.com>,
	Jeff Garzik <jeff@...zik.org>,
	Mario Schwalbe <schwalbe@....tu-dresden.de>,
	linux-kernel@...r.kernel.org,
	Linux IDE mailing list <linux-ide@...r.kernel.org>
Subject: Re: [PATCH] ide: Fix ata_id_has_dword_io to return DWORD I/O support properly

On Friday 19 December 2008, Alan Cox wrote:
> > Sure, we can always improve things further later.  However Mario's patch
> > is _definitely_ an improvement over the _current_ code.  Don't you agree?
> 
> No actually I don't. The current head dev code checks ATA > 7 as the
> indicator that this bit is used for treacherous computing. That means the
> behaviour for all the older drives is clearly back compatible with old
> Linux behaviour.
> 
> Doing it that way around means we don't have any worries about changing
> existing behaviours.

Please try to verify old Linux behaviour compatiblity statement with
some ATA-[2..7] devices...  They have old ATA-1 bit set to _zero_...

Mario: I don't have anymore time to spend on fixing libata problems so
I'll be leaving ata_id_has_dword_io() issues up to libata maintainers,
sorry for inconvenience!

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/