[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081219215347.GG2351@elte.hu>
Date: Fri, 19 Dec 2008 22:53:47 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc: Toshikazu Nakayama <nakayama.ts@...s.nec.co.jp>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: fix discarding message when recursion_bug
* Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>
> Impact: fix
>
> When recursion_bug is true, kernel discards original message because printk_buf
> contains recursion_bug_msg with NULL terminator. The sizeof(recursion_bug_msg)
> makes this, use strlen() to get correct length without NULL terminator.
>
> Reported-by: Toshikazu Nakayama <nakayama.ts@...s.nec.co.jp>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> ---
> kernel/printk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Good one - applied to tip/core/printk, thanks!
Btw., i'm curious: in what situation was such recursion observed, and how
did the kernel behave? You saw a truncated recursion message in dmesg - or
was it worse?
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists