linux-kernel - Re: [PATCH, v5] 9p: don't print IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4e6962a0812191407g40e14e8fw2e08f7e4e812389d@mail.gmail.com>
Date:	Fri, 19 Dec 2008 16:07:53 -0600
From:	"Eric Van Hensbergen" <ericvh@...il.com>
To:	"Duane Griffin" <duaneg@...da.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	"Al Viro" <viro@...iv.linux.org.uk>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Ron Minnich" <rminnich@...dia.gov>,
	"Latchesar Ionkov" <lucho@...kov.net>,
	v9fs-developer@...ts.sourceforge.net
Subject: Re: [PATCH, v5] 9p: don't print IS_ERR strings

NAK - the print is a debug to mark function entry when debugging is on
-- it is not intended to show only success.  If an erroneous s will
cause the print to break then perhaps it should be parameterized, but
the entire print shouldn't be pushed inside the if statement.

            -eric


On Fri, Dec 19, 2008 at 2:47 PM, Duane Griffin <duaneg@...da.com> wrote:
> Move the printk inside the !IS_ERR test.
>
> Cc: Eric Van Hensbergen <ericvh@...il.com>
> Cc: Ron Minnich <rminnich@...dia.gov>
> Cc: Latchesar Ionkov <lucho@...kov.net>
> Cc: v9fs-developer@...ts.sourceforge.net
> Signed-off-by: Duane Griffin <duaneg@...da.com>
> ---
>
> Unchanged from original version.
>
>  fs/9p/vfs_inode.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 8fddfe8..c50d555 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -1022,9 +1022,10 @@ v9fs_vfs_put_link(struct dentry *dentry, struct nameidata *nd, void *p)
>  {
>        char *s = nd_get_link(nd);
>
> -       P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s);
> -       if (!IS_ERR(s))
> +       if (!IS_ERR(s)) {
> +               P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s);
>                __putname(s);
> +       }
>  }
>
>  /**
> --
> 1.6.0.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/