linux-kernel - Re: [PATCH] fix some code style that line over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081219063415.GB3309@helight>
Date:	Fri, 19 Dec 2008 14:34:15 +0800
From:	Zhenwen Xu <helight.xu@...il.com>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix some code style that line over 80 characters

On Thu, Dec 18, 2008 at 07:30:59PM +0000, Russell King wrote:
> On Thu, Dec 18, 2008 at 11:26:17AM -0800, Randy Dunlap wrote:
> > On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:
> > 
> > > On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> > > > -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > > > +static inline struct
> > > > +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > > 
> > > NAK!
> > 
> > OK, but please includes reason(s) for NAKs...
> 
> I can provide a reason - it splits "struct" and the structure name
> across different lines.  That manes 'struct s3c2410_platform_i2c'
> hard to grep for.
yes, it should be:
static inline
struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> 
> -- 
> Russell King
>  Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
>  maintainer of:

-- 
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org
My Studio:	http://dim4.cn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/