linux-kernel - Re: [PATCH] sh: maple: add Maple controller as a joystick device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812201228.20767.dmitry.torokhov@gmail.com>
Date:	Sat, 20 Dec 2008 12:28:20 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Adrian McMenamin <adrian@...golddream.dyndns.info>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"linux-sh" <linux-sh@...r.kernel.org>,
	"linux-input" <linux-input@...r.kernel.org>,
	Paul Mundt <lethal@...ux-sh.org>, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] sh: maple: add Maple controller as a joystick device

On Saturday 20 December 2008 10:26:54 Adrian McMenamin wrote:
> +       mdev = to_maple_dev(dev);
> +       if (!mdev) {
> +               error = EINVAL;
> +               goto fail;
> +       }
> +       
> +       mdrv = to_maple_driver(dev->driver);
> +       if (!mdrv) {
> +               error = EINVAL;
> +               goto fail;
> +       }

This will never happen - to_maple_* are simple wrappers around container_of 
and so the result will never be NULL but some small offset from it if dev is 
NULL. I'm staying on the old version of the patch with small fixups.

-- 
Dmitry