linux-kernel - Re: [PATCH v7 4/8] sched: nominate preferred wakeup cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081220075418.GA2435@elte.hu>
Date:	Sat, 20 Dec 2008 08:54:18 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	svaidy@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	suresh.b.siddha@...el.com, venkatesh.pallipadi@...el.com,
	a.p.zijlstra@...llo.nl, dipankar@...ibm.com,
	balbir@...ux.vnet.ibm.com, vatsa@...ux.vnet.ibm.com,
	ego@...ibm.com, andi@...stfloor.org, davecb@....com,
	tconnors@...ro.swin.edu.au, maxk@...lcomm.com,
	gregory.haskins@...il.com, pavel@...e.cz,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH v7 4/8] sched: nominate preferred wakeup cpu


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Sat, 20 Dec 2008 10:06:38 +0530 Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com> wrote:
> 
> > > 
> > > kernel/sched.c: In function 'schedule':
> > > kernel/sched.c:3679: warning: 'active_balance' may be used uninitialized in this function
> > > 
> > > This warning is correct - the code is buggy.
> > 
> > Yes this is my code bug.  I did not see the warning in sched.c.  Is
> > there any build option that I need to pass in order to get -Wall
> > effect?
> 
> That was just with plain old kbuild: `make allmodconfig;make'.
> 
> That warning was produced by gcc-4.0.2.  If you're using something more 
> recent then gcc has regressed.

hm, it didnt trigger here with gcc 4.3 - and the condition is serious. 
I've applied the fix, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/