linux-kernel - Re: [PATCH] USBHID: Make Boot Protocol drivers depend on EMBEDDED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0812212247090.26265@jikos.suse.cz>
Date:	Sun, 21 Dec 2008 22:48:21 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Parag Warudkar <parag.lkml@...il.com>
cc:	Anssi Hannula <anssi.hannula@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, linux-input@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] USBHID: Make Boot Protocol drivers depend on EMBEDDED

On Sun, 21 Dec 2008, Parag Warudkar wrote:

> The usbmouse and usbkbd modules are not supposed to be used with regular 
> USB mice and keyboards. Make them depend on EMBEDDED to prevent them from 
> being built and loaded on non-EMBEDDED configs.
> 
> Signed-off-by: Parag Warudkar <parag.lkml@...il.com>
> 
> diff --git a/drivers/hid/usbhid/Kconfig b/drivers/hid/usbhid/Kconfig
> index 5d9aa95..4edb3be 100644
> --- a/drivers/hid/usbhid/Kconfig
> +++ b/drivers/hid/usbhid/Kconfig
> @@ -45,7 +45,7 @@ config USB_HIDDEV
>  	  If unsure, say Y.
>  
>  menu "USB HID Boot Protocol drivers"
> -	depends on USB!=n && USB_HID!=y
> +	depends on USB!=n && USB_HID!=y && EMBEDDED
>  
>  config USB_KBD
>  	tristate "USB HIDBP Keyboard (simple Boot) support"

So do I get it right that the only reason of the problem you were seeing 
was that in the 2.6.27 kernel you have compiled usbhid module, which was 
then used for driving your mouse,but in 2.6.28-rcX you compiled and used 
'usbmouse' instead, and therefore this is not a regression?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/