linux-kernel - Re: [PATCH 1/33] Documentation: Make static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081222113816.bf8be24b.randy.dunlap@oracle.com>
Date:	Mon, 22 Dec 2008 11:38:16 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	linux-doc@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/33] Documentation: Make static

On Tue, 09 Dec 2008 17:55:21 +0100 Roel Kluin wrote:

> Sparse asked whether these could be static.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

>  Documentation/DocBook/procfs_example.c |    2 +-
>  Documentation/connector/cn_test.c      |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/procfs_example.c b/Documentation/DocBook/procfs_example.c
> index 8c6396e..db06753 100644
> --- a/Documentation/DocBook/procfs_example.c
> +++ b/Documentation/DocBook/procfs_example.c
> @@ -54,7 +54,7 @@ static struct proc_dir_entry *example_dir, *foo_file,
>  	*bar_file, *jiffies_file, *symlink;
>  
>  
> -struct fb_data_t foo_data, bar_data;
> +static struct fb_data_t foo_data, bar_data;
>  
>  
>  static int proc_read_jiffies(char *page, char **start,
> diff --git a/Documentation/connector/cn_test.c b/Documentation/connector/cn_test.c
> index be7af14..b984b5b 100644
> --- a/Documentation/connector/cn_test.c
> +++ b/Documentation/connector/cn_test.c
> @@ -32,7 +32,7 @@ static char cn_test_name[] = "cn_test";
>  static struct sock *nls;
>  static struct timer_list cn_test_timer;
>  
> -void cn_test_callback(void *data)
> +static void cn_test_callback(void *data)
>  {
>  	struct cn_msg *msg = (struct cn_msg *)data;
>  


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/