linux-kernel - Re: [PATCH] failslab for SLUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Dec 2008 16:22:23 +0100
From:	Johannes Weiner <hannes@...xchg.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Akinobu Mita <akinobu.mita@...il.com>,
	linux-kernel@...r.kernel.org,
	Christoph Lameter <cl@...ux-foundation.org>,
	Matt Mackall <mpm@...enic.com>, linux-mm@...ck.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] failslab for SLUB

On Tue, Dec 23, 2008 at 04:44:26PM +0200, Pekka Enberg wrote:
> Hi Hannes,
> 
> On Tue, 2008-12-23 at 15:43 +0100, Johannes Weiner wrote:
> > >  static inline void *____cache_alloc(struct kmem_cache *cachep,
> > gfp_t flags)
> > >  {
> > >  	void *objp;
> > > @@ -3381,7 +3316,7 @@ __cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid,
> > >  	unsigned long save_flags;
> > >  	void *ptr;
> > >  
> > > -	if (should_failslab(cachep, flags))
> > > +	if (slab_should_failslab(cachep, flags))
> > 
> > should_failslab()?
> 
> No, look at what slab_should_failslab() does. We need to exclude
> cache_cache in SLAB but not in SLUB.

Ah, crap.  I missed that small '+' and thought it had been dropped. 

Sorry, Pekka.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/