| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <m3ocz2ua3w.fsf@maximus.localdomain> Date: Tue, 23 Dec 2008 17:31:15 +0100 From: Krzysztof Halasa <khc@...waw.pl> To: Håkon Løvdal <hlovdal@...il.com> Cc: "Hannes Eder" <hannes@...neseder.net>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement "Håkon Løvdal" <hlovdal@...il.com> writes: > For this specific issue the important aspect is to improve readability > (and not just eventually satisfy some warning from a tool), which I > assume there is no disagrement on. Precisely. > Now what constitutes improved > readbility on the other hand is another issue, and I guess there are > next to as many oppinions as developers... :) Yes. Thus the brackets (or lack of them) of do-while loops should never be forced as a part of coding standard/tools. This is just an unimportant detail of personal style and trying to force it is simply damaging to all of us. > Of secondary importance is the benefit that always using brackets > makes them much more merge friendly. There are many ways to make the code more merge friendly at a cost of readability. Hope we don't go this way. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists