linux-kernel - Re: TSC not updating after resume: Bug or Feature?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812230128.29586.rjw@sisk.pl>
Date:	Tue, 23 Dec 2008 01:28:28 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Fabio Comolli <fabio.comolli@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <srostedt@...hat.com>, dsaxena@...xity.net,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	toralf.foerster@....de
Subject: Re: TSC not updating after resume: Bug or Feature?

On Monday, 22 of December 2008, Thomas Gleixner wrote:
> Fabio,
> 
> On Mon, 22 Dec 2008, Fabio Comolli wrote:
> 
> > OK, it seems that you got it.
> > 
> > The system survived two hibernation / resume cycles without triggering
> > the warning and, probably the most important part, the dmesg does not
> > have any "jumps" before the "Force enable HPET on resume" line as
> > before:
> > 
> > [  275.647704] PM: Creating hibernation image:
> > [  275.648005] PM: Need to copy 177844 pages
> > [  275.648005] Intel machine check architecture supported.
> > [  275.648005] Intel machine check reporting enabled on CPU#0.
> > [  275.648005] Force enabled HPET at resume
> > [  275.648005] ACPI: Waking up from system sleep state S4
> > [  275.669038] ACPI: EC: non-query interrupt received, switching to
> > interrupt mode
> > [  275.740697] pcieport-driver 0000:00:01.0: setting latency timer to 64
> > [  275.740781] pcieport-driver 0000:00:1c.0: setting latency timer to 64
> > [  275.740786] pciehp 0000:00:1c.0:pcie02: pciehp_resume ENTRY
> > 
> > ...and so on.
> > 
> > As i mentioned in the bug report, to be sure that the bug doesn't
> > trigger I have to wait at least on day and > 10 hibernation / resumee
> > cycles.
> 
> Sure.
>  
> > But with your first patch the bug triggered at the second cycle, so
> > I'm optimist :-)
> > 
> > I'll keep you informed. Many thanks in advance,
> 
> Many thanks to you for following up on this.

Well, thanks a lot to you both for debugging this and finding a fix.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/