linux-kernel - Re: [PATCH -tip] Switch arm defconfig files from CONFIG_CLASSIC_RCU to CONFIG_TREE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081223215948.GA16137@linux.vnet.ibm.com>
Date:	Tue, 23 Dec 2008 13:59:48 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	akpm@...ux-foundation.org, ralf@...ux-mips.org,
	kernel@...tstofly.org, hskinnemoen@...el.com, cooloney@...nel.org,
	tony.luck@...el.com, geert@...ux-m68k.org, zippel@...ux-m68k.org,
	jwboyer@...ux.vnet.ibm.com, mporter@...nel.crashing.org,
	grant.likely@...retlab.ca, paulus@...ba.org,
	benh@...nel.crashing.org, dhowells@...hat.com,
	yasutake.koichi@...panasonic.com, lethal@...ux-sh.org,
	hpa@...or.com
Subject: Re: [PATCH -tip] Switch arm defconfig files from
	CONFIG_CLASSIC_RCU to CONFIG_TREE_RCU.

On Tue, Dec 23, 2008 at 03:25:42PM +0100, Ingo Molnar wrote:
> 
> * paulmck@...ux.vnet.ibm.com <paulmck@...ux.vnet.ibm.com> wrote:
> 
> > From: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > 
> > Only for testing in -tip and -next, not yet for inclusion into mainline.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > ---
> >  arch/arm/configs/afeb9260_defconfig     |    2 +-
> >  arch/arm/configs/am200epdkit_defconfig  |    2 +-
> >  arch/arm/configs/cm_x300_defconfig      |    2 +-
> >  arch/arm/configs/corgi_defconfig        |    2 +-
> >  arch/arm/configs/csb637_defconfig       |    2 +-
> >  arch/arm/configs/eseries_pxa_defconfig  |    2 +-
> >  arch/arm/configs/ezx_defconfig          |    2 +-
> >  arch/arm/configs/imx27ads_defconfig     |    2 +-
> >  arch/arm/configs/jornada720_defconfig   |    2 +-
> >  arch/arm/configs/kirkwood_defconfig     |    2 +-
> >  arch/arm/configs/loki_defconfig         |    2 +-
> >  arch/arm/configs/magician_defconfig     |    2 +-
> >  arch/arm/configs/mv78xx0_defconfig      |    2 +-
> >  arch/arm/configs/mx31ads_defconfig      |    2 +-
> >  arch/arm/configs/mx31litekit_defconfig  |    2 +-
> >  arch/arm/configs/omap3_beagle_defconfig |    2 +-
> >  arch/arm/configs/omap_h2_1610_defconfig |    2 +-
> >  arch/arm/configs/omap_ldp_defconfig     |    2 +-
> >  arch/arm/configs/orion5x_defconfig      |    2 +-
> >  arch/arm/configs/overo_defconfig        |    2 +-
> >  arch/arm/configs/palmz72_defconfig      |    2 +-
> >  arch/arm/configs/pcm037_defconfig       |    2 +-
> >  arch/arm/configs/pcm038_defconfig       |    2 +-
> >  arch/arm/configs/s3c2410_defconfig      |    2 +-
> >  arch/arm/configs/spitz_defconfig        |    2 +-
> >  arch/arm/configs/tct_hammer_defconfig   |    2 +-
> >  arch/arm/configs/viper_defconfig        |    2 +-
> >  arch/arm/configs/xm_x2xx_defconfig      |    2 +-
> >  28 files changed, 28 insertions(+), 28 deletions(-)
> 
> ouch!
> 
> There's a much more shrewd method to achieve the same, via 2 lines total 
> patch:
> 
> Change the name of CONFIG_CLASSIC_RCU to something else such as 
> CONFIG_FLAT_RCU. That does all the magic and more: all configs will 
> default to tree-rcu - not just defconfigs! Agreed?

Good point!

> [ I think the gene of laziness is probably more developed in my genome
>   than in yours. It is a very useful trait ;-) ]

Lazy or not, your approach is much better than what I was doing.  ;-)

Two patches in subsequent emails: the first gets rid of a duplicate
RCU_CPU_STALL_DETECTOR config declaration (noticed in this exercise --
one each from the CLASSIC_RCU and TREE_RCU stall detectors), and the
second changes the default to TREE_RCU as you suggest.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/