linux-kernel - Re: [2.6.28-rc] Sata soft reset filling log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49504B8C.8080907@kernel.org>
Date:	Tue, 23 Dec 2008 11:23:08 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Justin Madru <jdm64@...ab.com>
CC:	lkml <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-ide@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [2.6.28-rc] Sata soft reset filling log

Hello,

Justin Madru wrote:
>> Ah.. strange.  The command protocol is ATAPI_PROT_NODATA and the drive
>> should be setting DRQ to receive CDB but it's not doing that.
>> Strange.  It could be that the drive is a little bit tardy with DRQ -
>> ie. setting DRQ after clearing BUSY and ata_piix is now successfully
>> hitting the small window for some reason.
>>
>> Does the attached patch make any difference?
>>
>> Thanks.
>>
>>   
> Ok, I applied your patch. Unfortunately, it didn't fix my problem.
> I now get a different, but similar message; not sure if it happens less
> frequently - still often though.

Aiee...

> What changes happened between .27 and .28 could've caused this?
> Anyways, below is what I get now (with your patch), including the
> frequency of occurrence.

I have no idea and I'm afraid we'll need a bisection here. :-( Can you
please try the attached patch?

Thanks.

-- 
tejun

View attachment "DRQ-debug-1.patch" of type "text/x-patch" (669 bytes)