linux-kernel - Re: [PATCH] sata_sil: add Large Block Transfer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081223101033.70c74ec7@lxorguk.ukuu.org.uk>
Date:	Tue, 23 Dec 2008 10:10:33 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Tejun Heo <tj@...nel.org>
Cc:	Robert Hancock <hancockr@...w.ca>, ide <linux-ide@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sata_sil: add Large Block Transfer support

> > We know the register's always MMIO on this controller, so it's slightly
> > more optimal to avoid the conditional in there.
> 
> Yeah, by a small margin but I think the consensus was to use
> ioread/write no matter what if it's mapped using iomap.  I don't think
> we guarantee iomapped address == mmio address after all.

This was discussed before - using writel/readl on iomap is wrong. It may
happen to work on some platforms but shouldn't be expected to work on all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/