linux-kernel - Re: [PATCH -mm 1/3] USB: FHCI: Driver should be responsible for managing endpoint queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0812241752330.917-100000@netrider.rowland.org>
Date:	Wed, 24 Dec 2008 17:54:21 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Anton Vorontsov <avorontsov@...mvista.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <greg@...ah.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Timur Tabi <timur@...escale.com>,
	Li Yang <leoli@...escale.com>, <linux-usb@...r.kernel.org>,
	<linuxppc-dev@...abs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 1/3] USB: FHCI: Driver should be responsible for
 managing endpoint queues

On Wed, 24 Dec 2008, Anton Vorontsov wrote:

> Follow these changes for the FHCI driver:
> 
> commit e9df41c5c5899259541dc928872cad4d07b82076
> Author: Alan Stern <stern@...land.harvard.edu>
> Date:   Wed Aug 8 11:48:02 2007 -0400
> 
> USB: make HCDs responsible for managing endpoint queues

On the whole this looks good.

> --- a/drivers/usb/host/fhci-q.c
> +++ b/drivers/usb/host/fhci-q.c
> @@ -200,6 +200,9 @@ void urb_complete_free(struct fhci_hcd *fhci, struct urb *urb)
>  		else
>  			urb->status = 0;
>  	}
> +
> +	usb_hcd_unlink_urb_from_ep(fhci_to_hcd(fhci), urb);
> +
>  	spin_unlock(&fhci->lock);
>  
>  	usb_hcd_giveback_urb(fhci_to_hcd(fhci), urb, urb->status);

For the future you might think about not using urb->status at all.  The 
intention is eventually to remove that field.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/