linux-kernel - Re: [PATCH] ftrace: enable format arguments checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0812232233460.21172@gandalf.stny.rr.com>
Date:	Tue, 23 Dec 2008 22:36:40 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: enable format arguments checking


On Wed, 24 Dec 2008, Lai Jiangshan wrote:

> Lai Jiangshan wrote:
> > format arguments checking for ftrace_printk() is __printf(1, 2),
> > not __printf(1, 0).
> > 
> > Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> > ---
> > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> > index 9c5bc6b..0c71788 100644
> > --- a/include/linux/ftrace.h
> > +++ b/include/linux/ftrace.h
> > @@ -210,7 +210,7 @@ extern void ftrace_dump(void);
> >  static inline void
> >  ftrace_special(unsigned long arg1, unsigned long arg2, unsigned long arg3) { }
> >  static inline int
> > -ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 0)));
> 
> Hi, Steven Rostedt
> 	Did you notice this patch?
> 	This patch changed a char in a line: s/0/2/. It enables the format checking.
> 
> 	Lai.
> 
> > +ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
> >  
> >  static inline int
> >  ftrace_printk(const char *fmt, ...)
> > 

Ah yes, sorry, I'm rushing to get some other things done because I'll be 
on holiday tomorrow through to Jan 5th.

I'll pull it into the rest of my next series.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/