linux-kernel - Re: [PATCH] sh: maple: Robust checking for errors on maple keyboard initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200812241159.15332.vapier@gentoo.org>
Date:	Wed, 24 Dec 2008 11:59:13 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Adrian McMenamin <adrian@...golddream.dyndns.info>
Cc:	lkmL <linux-kernel@...r.kernel.org>,
	"linux-input" <linux-input@...r.kernel.org>,
	"linux-sh" <linux-sh@...r.kernel.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	Matt Fleming <matt@...sole-pimps.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] sh: maple: Robust checking for errors on maple keyboard initialisation

On Saturday 20 December 2008 13:25:27 Adrian McMenamin wrote:
> -	maple_set_drvdata(mdev, NULL);
> -	return error;
> +fail:
> +	return -error;

same comment as for the joystick driver ... it's weird and i'm pretty sure 
incorrect due to other functions setting error as well as this driver.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (836 bytes)