linux-kernel - Re: linux-next: parsing mem=700M broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812251358.13635.rusty@rustcorp.com.au>
Date:	Thu, 25 Dec 2008 13:58:12 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Yinghai Lu <yinghai@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: linux-next: parsing mem=700M broken

On Thursday 25 December 2008 01:14:35 Hugh Dickins wrote:
> On Wed, 24 Dec 2008, Rusty Russell wrote:
> > mem= is actually easy, memmap= is harder.  This is tested and pushed.
> 
> Thanks, that gets my "mem=700M" respected on x86_32 and x86_64.
> But (of course: it's a patch to arch/x86) doesn't help at all on
> ppc64; and I presume other architectures also remain broken...

No, the problem is that early_param() get parsed *earlier* with these
changes.  x86 relied on the e820 map already being set up.  Most archs
(like powerpc) just set a "memory_limit" and handle it later; this
is in fact how the vast majority of early_param() work.

This cleanup is getting hairier, however we should see it as a chance
to clean some of this code too I guess...

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/