linux-kernel - Re: [PATCH 2/2 -tip] irq: kstat_incr_irqs_this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081226091822.GE27747@elte.hu>
Date:	Fri, 26 Dec 2008 10:18:22 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Wang Chen <wangchen@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 2/2 -tip] irq: kstat_incr_irqs_this_cpu only needs one
	parameter


* Wang Chen <wangchen@...fujitsu.com> wrote:

> desc is useless for kstat_incr_irqs_this_cpu.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> ---
>  arch/x86/kernel/visws_quirks.c |    2 +-
>  arch/x86/xen/spinlock.c        |    2 +-
>  include/linux/kernel_stat.h    |    3 +--
>  kernel/irq/chip.c              |   10 +++++-----
>  kernel/irq/handle.c            |    4 ++--
>  5 files changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/kernel/visws_quirks.c b/arch/x86/kernel/visws_quirks.c
> index 0c9667f..bd37460 100644
> --- a/arch/x86/kernel/visws_quirks.c
> +++ b/arch/x86/kernel/visws_quirks.c
> @@ -633,7 +633,7 @@ static irqreturn_t piix4_master_intr(int irq, void *dev_id)
>  	/*
>  	 * handle this 'virtual interrupt' as a Cobalt one now.
>  	 */
> -	kstat_incr_irqs_this_cpu(realirq, desc);
> +	kstat_incr_irqs_this_cpu(realirq);
>  
>  	if (likely(desc->action != NULL))
>  		handle_IRQ_event(realirq, desc->action);

'desc' is needed in the sparseirq model:

#define kstat_incr_irqs_this_cpu(irqno, DESC) \
        ((DESC)->kstat_irqs[smp_processor_id()]++)

See:

 http://people.redhat.com/mingo/tip.git/README

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/