[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49569AF1.8050205@zytor.com>
Date: Sat, 27 Dec 2008 13:15:29 -0800
From: "H. Peter Anvin" <hpa@...or.com>
To: Ingo Molnar <mingo@...e.hu>
CC: Sam Ravnborg <sam@...nborg.org>,
Mike Frysinger <vapier@...too.org>, tglx@...utronix.de,
mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace
Ingo Molnar wrote:
> * Sam Ravnborg <sam@...nborg.org> wrote:
>
>> On Sat, Dec 27, 2008 at 01:50:04AM -0500, Mike Frysinger wrote:
>>> Use __asm__/__inline__ rather than asm/inline for all the functions
>>> exported to userspace.
>> I will imagine that we will see cleanup patches converting
>> these back to inline/asm.
>> How about doing this conversion as part of the headers_install.pl
>> script so we know it is always correct?
>>
>> Then we can keep the familiar inline/asm in the kernel headers
>> and always use the correct __asm__, __inline__ version for our
>> exported headers.
>
> or name it __asm__exported__ to make sure it isnt cleaned up away.
>
Seems better to do it automatically. We end up with cleaner-looking
code that way, too.
It doesn't solve the need for symbols in inline functions in exported
headers to have __ prefixes, though.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists